🩹 [Patch]: Refactor font data retrieval to use GitHub PowerShell #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Get-GitHubReleaseAsset
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the font data retrieval mechanism in the Update-FontsData.ps1 script to use GitHub PowerShell commands instead of direct REST API calls. The changes aim to improve code readability and maintainability by leveraging more structured PowerShell functions.
Key changes include:
- Replacing
Invoke-RestMethodwithGet-GitHubReleasefor fetching release data - Using
Get-GitHubReleaseAssetinstead of direct property access for asset URLs - Converting object creation from hashtables to
[PSCustomObject]for better structure
Co-authored-by: Copilot <[email protected]>
MariusStorhaug
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the
scripts/Update-FontsData.ps1script to improve the retrieval of font data from the Nerd Fonts repository. The changes replace the use ofInvoke-RestMethodwith a more structured approach using custom PowerShell functions, enhancing readability and maintainability.Enhancements to font data retrieval:
Invoke-RestMethodwithGet-GitHubReleaseto fetch the latest release data from the Nerd Fonts repository.browser_download_urlproperty under assets on a release, withGet-GitHubReleaseAssetto fetch the URL of the assets that are added to the release.[PSCustomObject]instead of[ordered]@for better view and troubleshooting.Type of change
Checklist